Re: [PATCH tip/core/urgent 1/4] rcu: add rcu_access_pointer andrcu_dereference_protected

From: Paul E. McKenney
Date: Fri Apr 09 2010 - 12:56:25 EST


On Fri, Apr 09, 2010 at 10:10:11AM +0100, David Howells wrote:
> Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> > +#define rcu_access_pointer(p) ((void *)ACCESS_ONCE(p))
> > ...
> > +#define rcu_access_pointer(p) ((void *)ACCESS_ONCE(p))
>
> There's no difference between your two versions of rcu_access_pointer(), so
> you could move that whole construct outside of the #ifdef'ed section.
>
> Other than that:
>
> Acked-by: David Howells <dhowells@xxxxxxxxxx>

Good point, will rework and resubmit.

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/