Re: [PATCH #3] reiserfs: Fix permissions on .reiserfs_priv

From: Matt McCutchen
Date: Thu Apr 08 2010 - 18:40:51 EST


On Thu, 2010-04-08 at 23:38 +0200, Edward Shishkin wrote:
> Jeff Mahoney wrote:
> > [...] This patch resolves the issue by properly hiding .reiserfs_priv. This
> > was the intent of the xattr poisoning code, but it appears to have
> > never worked as expected. This is fixed by using d_revalidate instead
> > of d_compare. [...]

The patch seems to rely on the fact that the priv_root dentry is stuck
in the dcache for as long as the filesystem is mounted, so that attempts
to follow ".reiserfs_priv" are guaranteed to match that dentry in the
cache and be refused by xattr_hide_revalidate. Is my understanding
correct?

--
Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/