Re: [PATCH] radix_tree_tag_get() is not as safe as the docs makeout

[Linus Torvalds]

On Tue, 6 Apr 2010, David Howells wrote:
>
> radix_tree_tag_get() is not safe to use concurrently with radix_tree_tag_set()
> or radix_tree_tag_clear().  The problem is that the double tag_get() in
> radix_tree_tag_get():
 [ snip snip ]

Looks like a reasonable patch, but the one thing you didn't say is whether 
there is any code that relies on the incorrectly documented behavior?

How did you find this? Do we need to fix actual code too? The only user 
seems to be your fscache/page.c thing, and I'm not seeing any locking 
except for the rcu locking that is apparently not sufficient.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/