Re: [PATCH] raw: fsync method is now required

[Jan Kara]

On Sun 04-04-10 10:45:23, Anton Blanchard wrote:
> Commit 148f948ba877f4d3cdef036b1ff6d9f68986706a (vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode) broke the raw driver.
> 
> We now call through generic_file_aio_write -> generic_write_sync ->
> vfs_fsync_range. vfs_fsync_range has:
> 
>         if (!fop || !fop->fsync) {
>                 ret = -EINVAL;
>                 goto out;
>         }
> 
> But drivers/char/raw.c doesn't set an fsync method. 
> 
> We have two options: fix it or remove the raw driver completely. I'm happy
> to do either, the fact this has been broken for so long suggests it is
> rarely used.
> 
> The patch below adds an fsync method to the raw driver. My knowledge of the
> block layer is pretty sketchy so this could do with a once over.
  Thanks for catching this. The patch looks fine.
 
> If we instead decide to remove the raw driver, this patch might still be
> useful as a backport to 2.6.33 and 2.6.32.
  Oracle databases still use raw devices so I don't think we should remove
them.

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/