Re: [PATCH] /dev/mem: Allow rewinding

[AmÃrico Wang]

On Tue, Apr 6, 2010 at 5:19 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le lundi 05 avril 2010 Ã 23:04 +0200, Eric Dumazet a Ãcrit :
>> Andrew, commit dcefafb6ac90ece8d68a6c203105f3d313e52da4 seems to be the
>> problem.
>>
>> It breaks rewinds (negative offsets to lseek (... SEEK_CUR))
>>
>
> Here is a patch to make rewind working again on /dev/mem
>
> [PATCH] /dev/mem: Allow rewinding
>
> commit dcefafb6 (/dev/mem: dont allow seek to last page)
> inadvertently disabled rewinding on /dev/mem.
>
> This broke x86info for example.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> ---
> diff --git a/drivers/char/mem.c b/drivers/char/mem.c
> index 1f3215a..3973a1d 100644
> --- a/drivers/char/mem.c
> +++ b/drivers/char/mem.c
> @@ -710,11 +710,6 @@ static loff_t memory_lseek(struct file *file, loff_t offset, int orig)
> Â Â Â Âswitch (orig) {
> Â Â Â Âcase SEEK_CUR:
> Â Â Â Â Â Â Â Âoffset += file->f_pos;
> - Â Â Â Â Â Â Â if ((unsigned long long)offset <
> - Â Â Â Â Â Â Â Â Â (unsigned long long)file->f_pos) {
> - Â Â Â Â Â Â Â Â Â Â Â ret = -EOVERFLOW;
> - Â Â Â Â Â Â Â Â Â Â Â break;
> - Â Â Â Â Â Â Â }

Why completely dropping the overflow check? What you need to do is just
adding the 'offset < 0' case check.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/