Re: [PATCH v3] OMAP: Fix for bus width which improves SD card'speformance.

[Felipe Balbi]

Hi,

On Mon, Apr 05, 2010 at 12:19:29PM -0500, Madhusudhan wrote:
> Since the first if command already checks for the 8-bit the second check
> like >= 4 is definitely not readable in my opinion.

how come ???

> Functionally do you see anything wrong with this patch??

functionally no, but (hypothetical situation) and if on
omap4/5/6/whatever, omap controller supports a bigger bus width then
you'll have to add a line like:

+	if (mmc_slot(host).wires == 16)
+		mmc->caps |= (MMC_CAP_16_BIT_DATA | MMC_CAP_8_BIT_DATA |
+				MMC_CAP_4_BIT_DATA);
-	if (mmc_slot(host).wires == 8)
+	else if (mmc_slot(host).wires == 8)

do you see the problem ?? In my opinion it doesn't scale well.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/