Re: BUG: null pointer deref in dmar_ir_support

From: Ingo Molnar
Date: Fri Apr 02 2010 - 14:20:59 EST



* Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:

> @@ -1640,8 +1640,10 @@ int __init APIC_init_uniprocessor(void)
> }
> #endif
>
> +#ifndef CONFIG_SMP
> enable_IR_x2apic();
> default_setup_apic_routing();
> +#endif

Instead of adding yet another ugly #ifdef please hide these details properly,
by making enable_IR_x2apic() and default_setup_apic_routing() a NOP on !SMP.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/