Re: [PATCH] proc: pagemap: Hold mmap_sem during page walk

From: Matt Mackall
Date: Fri Apr 02 2010 - 10:31:17 EST


On Fri, Apr 02, 2010 at 09:11:29AM +0900, KAMEZAWA Hiroyuki wrote:

> int ret = -ESRCH;
...
> + pm.len = PM_ENTRY_BYTES * (PAGEMAP_WALK_SIZE >> PAGE_SHIFT);
> + pm.buffer = kmalloc(pm.len, GFP_TEMPORARY);
> + if (!pm.buffer)
> goto out_mm;
...
> out_mm:
> mmput(mm);

Looks like this gets the wrong return code?

--
Mathematics is the supreme nostalgia of our time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/