Re: [RFC 7/9] ppp: use big tty mutex

[AmÃrico Wang]

On Wed, Mar 31, 2010 at 4:56 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> ppp interacts with the tty layer, so it should
> take the BTM instead of the BKL.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> Âdrivers/net/ppp_generic.c | Â 29 +++++++++++++++--------------
> Â1 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
> index 6d61602..bc89a1b 100644
> --- a/drivers/net/ppp_generic.c
> +++ b/drivers/net/ppp_generic.c
> @@ -40,7 +40,7 @@
> Â#include <linux/if_arp.h>
> Â#include <linux/ip.h>
> Â#include <linux/tcp.h>
> -#include <linux/smp_lock.h>
> +#include <linux/tty.h>
> Â#include <linux/spinlock.h>
> Â#include <linux/rwsem.h>
> Â#include <linux/stddef.h>
> @@ -362,7 +362,8 @@ static const int npindex_to_ethertype[NUM_NP] = {
> Â*/
> Âstatic int ppp_open(struct inode *inode, struct file *file)
> Â{
> - Â Â Â cycle_kernel_lock();
> + Â Â Â tty_lock();
> + Â Â Â tty_unlock();

I don't really get your point here. :) Why do you do this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/