Re: [PATCH 0/3] perf/core, x86: unify perfctr bitmasks

From: Robert Richter
Date: Tue Mar 30 2010 - 13:24:28 EST


On 30.03.10 18:55:13, Peter Zijlstra wrote:
> On Tue, 2010-03-30 at 17:59 +0200, Robert Richter wrote:
> > > + if (attr->type == PERF_TYPE_RAW)
> > > + return x86_pmu.raw_event(event);
> >
> > We could go on with this and move this into *_hw_config(), but so far
> > this change is fine to me. This would then remove .raw_event() at all.
> >
>
> Right, I did have a brief look at that, you mentioned this before to
> Cyrill IIRC, but the issue is that... ~brainwave~ how about the below..

I like your patch, thanks Peter.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/