Re: [PATCH] ARM: mach-sa1100: Put nanoEngine support back in the kernel.
From: Marcelo Jimenez
Date: Mon Mar 29 2010 - 15:11:03 EST
Hi Russel and Kristoffer,
On Sat, Mar 27, 2010 at 19:55, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
>
> Please don't include defconfigs along with other code.
Ok, I have removed the defconfig and put it in a separate patch.
>> +#include <linux/init.h>
>> +#include <linux/kernel.h>
>> +#include <linux/mtd/mtd.h>
>> +#include <linux/mtd/partitions.h>
>> +#include <linux/root_dev.h>
>> +#include <linux/tty.h>
>
> Do you really need tty.h in here?
No, I don't. :) Removed.
>> +/* Flash bank 0 */
>> +static struct mtd_partition nanoengine_partitions[] = {
>> + {
>> + .name = "nanoEngine boot firmware and parameter table",
>
> Each '{' should indent the next line by a tab.
Ok, that was another "line over 80 characters" warning. Fixed.
I will resubmit the patch, merged with the CPU FREQ patch, which is
where it belongs. And a better changelog.
Also I have removed Kristoffer's "Acked-by" because this is a changed version.
Regards,
Marcelo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/