Re: [PATCH] staging: winbond: wbhal_f.h Coding style fixes.

From: Dan Carpenter
Date: Mon Mar 29 2010 - 05:43:39 EST


On Sun, Mar 28, 2010 at 07:10:59PM +0200, Lars Lindley wrote:
> I fixed all checkpatch problems and also converted the
> function arguments from hungarian notation and CamelCase.
>

[snip]

> -#define hal_ibss_disconnect(_A) hal_stop_sync_bss(_A)
> +#define hal_ibss_disconnect(_A) (hal_stop_sync_bss(_A))

The parenthesis around hal_stop_sync_bss() aren't needed. They don't
hurt anything, but they're odd.

Also it appears that no one uses hal_ibss_disconnect().

So far as I'm concerned this can go in as is...
Acked-by: Dan Carpenter <error27@xxxxxxxxx>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/