Re: [patch] drm: sysfs files error handling

[Andi Kleen]

, Dan Carpenter wrote:
> In the original code we used "j" as an iterator but we used "i" as an
> index.
>
> -               for (j = 0; j<  i; j++)
> -                       device_remove_file(&connector->kdev,
> -&connector_attrs[i]);

I guess this really should be a attribute group anyways?

Typically when there's such a open coded loop it means the wrong
interfaces are being used.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/