Re: [PATCH] benet: Fix compile warnnings indrivers/net/benet/be_ethtool.c

From: David Miller
Date: Sat Mar 27 2010 - 11:32:00 EST


From: Ajit Khaparde <ajitkhaparde@xxxxxxxxx>
Date: Fri, 26 Mar 2010 22:46:18 +0530

> On 26/03/10 14:12 +0800, wzt.wzt@xxxxxxxxx wrote:
>> Fix the following warnings:
>>
>> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>> be_ethtool.c:493: warning: integer constant is too large for 'long' type
>>
>> Signed-off-by: Zhitong Wang <zhitong.wangzt@xxxxxxxxxxxxxxx>
>
> I would suggest using be2net instead of benet during the commit.
> be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c
>
> Acked-by: Ajit Khaparde <ajitk@xxxxxxxxxxxxxxxxx>

Well, you cannot be surprised that people will use "benet"
since that is the name of the directory the driver lives
under. It is not even referred to as "be2net" in the
MAINTAINERS entry.

I'm applying this fix as-is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/