Re: [PATCH 2/2] DMAENGINE: generic channel status v2

[Linus Walleij]

2010/3/27 Dan Williams <dan.j.williams@xxxxxxxxx>:

> Sidenote: one thing I notice via this exercise is that not every driver
> is triggering a descriptor cleanup in their device_tx_status()
> implementation.  It's really only needed for the drivers that will
> service requests from the async_tx api (now the minority), but something
> to keep in mind.  In some cases async_tx polls for completion on
> descriptor allocation failure, so either ->device_tx_status() or
> ->device_prep* needs to run descriptor reclaim.

Not that I designed this thing, but the idea of device_tx_status()
cleaning things up seems a bit kludgy, what about adding a new
control command to device_control() instead, like
DMA_CLEANUP_TX and require that you call this after a
polling async transfer has been found to be complete?

Is this thing supposed to be used for DMA hardware that cannot
trigger interrupts on completion by the way? That seems like the
natural reason...

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/