Re: [PATCH 0/4] dmaengine: Add driver for Xilinx MPMC

From: Grant Likely
Date: Fri Mar 26 2010 - 17:18:49 EST


On Wed, Mar 17, 2010 at 10:25 AM, Steven J. Magnani
<steve@xxxxxxxxxxxxxxx> wrote:
> This is a DMA engine driver for SDMA channels on a Xilinx Multi-Port
> Memory Controller (MPMC).
>
> Caveats:
> * The OF bus driver (part 4) is based on the fsldma driver and how I
>  thought the device and channels might be represented in a device tree blob.
>  As I don't use OF in my kernel, all I am able to do is verify that the code
>  compiles. Suggestions for improvement are especially welcome here.

If you're not using the OF bits, then don't worry about them yet.
They can be added later. of_platform is getting merged with platform
bus anyway, so one driver will work with both.

> * Similarly, I took a stab at DCR support based on the ll_temac driver
>  and some discussions about supporting both DCR and simple pointer access
>  to device registers. I'm working on Microblaze so cannot test the DCR code.

Again, don't bother with stuff you don't have. It can be added after the fact.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/