Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

From: Masami Hiramatsu
Date: Fri Mar 26 2010 - 11:44:48 EST


KOSAKI Motohiro wrote:
>> Hi Andrea,
>>
>> Andrea Gelmini wrote:
>>> tools/perf/util/probe-finder.c: string.h is included more than once.
>>
>> Would you mean that <string.h> and "string.h" are duplicated?
>> If so, NAK, sorry. Those are different, <string.h> is for
>> /usr/include/string.h, and "string.h" is for tools/perf/util/string.h.
>>
>> Thank you,
>
> I think this discussion suggested "string.h" should be renameed more review
> friendly name. probably.

Hmm, we'd better review files under tools/utils/include too. :(
(not sure why we have those files, because some files includes
headers from original include directory, as like as
"../../include/linux/blahblah.h")

Thank you,

--
Masami Hiramatsu
e-mail: mhiramat@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/