Re: [PATCH] Fix __vmalloc(), etc on MIPS for non-GPL modules

From: Anton Altaparmakov
Date: Fri Mar 26 2010 - 11:01:53 EST


Hi Ralf,

On 26 Mar 2010, at 14:52, Ralf Baechle wrote:
> On Thu, Mar 25, 2010 at 08:48:12PM +0000, Anton Altaparmakov wrote:
>> The commit 351336929ccf222ae38ff0cb7a8dd5fd5c6236a0 which can be seen
>> here:
>
> Which was in 2.6.26 ...

Yes. (-:

Embedded companies tend to use very old kernels. Usually 2.6.10-2.6.18 range. This is the fist time someone using MIPS architecture came up with a 2.6.27 kernel and linking failed hence my patch. I only personally test compilation across all kernels (2.6.10-latest) on x86 so I miss things like that happening...

>> I therefore propose that the EXPORT_SYMBOL_GPL(_page_cachable_default) is
>> changed to EXPORT_SYMBOL(_page_cachable_default) to re-instate the
>> ability for non-GPL modules to call __vmalloc(), vmap(), vm_map_ram(),
>> and such like.
>>
>> Here is a patch that does this. If you approve, please apply it.
>
> I approve - but applying would be easier if this patch had not been
> linewrapped ...

Sorry about that!!! I sent the patch using Pine and thought I was safe on that front but I probably did something wrong. )))-:

> Applied to master and -stable. Thanks!

Great, thanks!

Best regards,

Anton

> Ralf

--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/