Re: [patch 0/2] Run interrupt handlers always with interruptsdisabled

From: Alan Cox
Date: Fri Mar 26 2010 - 05:57:01 EST


> As long as it's rare (which it is) i dont see a problem: you can enable
> interrupts in the handler by using local_irq_enable(), like the IDE PIO
> drivers do. That way it's documented a bit better as well, because it shows
> the precise source of the latency, with a big comment explaining it, etc.

I don't think it's as rare as you think particularly in embedded, and the
moment you start explicitly using local_irq_enable() you've simply moved
the underlying problem back and made it far harder to grep for.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/