Re: [PATCH 1/2] sis-agp: Remove SIS 760, handled by amd64-agp

[FUJITA Tomonori]

On Wed, 24 Mar 2010 03:33:48 +0000
Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:

> SIS 760 is listed in the device tables for both amd64-agp and sis-agp.
> amd64-agp is apparently preferable since it has workarounds for some
> BIOS misconfigurations that sis-agp doesn't handle.
> 
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
>  drivers/char/agp/sis-agp.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)

Looks fine to me. Hopefully, amd64-agp can handle all SIS 760 systems.

Can we confirm that this can fix bugs reported in Debian's bug
tracking system (which you mentioned earlier)?


> diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis-agp.c
> index 6c3837a..95fdd4d 100644
> --- a/drivers/char/agp/sis-agp.c
> +++ b/drivers/char/agp/sis-agp.c
> @@ -415,14 +415,6 @@ static struct pci_device_id agp_sis_pci_table[] = {
>  		.subvendor	= PCI_ANY_ID,
>  		.subdevice	= PCI_ANY_ID,
>  	},
> -	{
> -		.class		= (PCI_CLASS_BRIDGE_HOST << 8),
> -		.class_mask	= ~0,
> -		.vendor		= PCI_VENDOR_ID_SI,
> -		.device		= PCI_DEVICE_ID_SI_760,
> -		.subvendor	= PCI_ANY_ID,
> -		.subdevice	= PCI_ANY_ID,
> -	},
>  	{ }
>  };
>  
> -- 
> 1.7.0
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/