Re: [PATCH v2] PL330: Add PL330 DMA controller driver

[Kyungmin Park]

On Fri, Mar 26, 2010 at 8:59 AM, jassi brar <jassisinghbrar@xxxxxxxxx> wrote:
> On Fri, Mar 26, 2010 at 8:12 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>> On Thu, Mar 25, 2010 at 3:27 PM, jassi brar <jassisinghbrar@xxxxxxxxx> wrote:
>>> On Fri, Mar 26, 2010 at 12:13 AM, Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>>>> It sounds like you just need to add an extension for the arch specific dma
>>>> api.
>>> I actually plan more than that.
>>> Apart from inefficient design, JoonYoung's driver has made some fatal
>>> assumptions
>>> about PL330, which will result in DMA aborts if used with SoCs that implement
>>> configuration of PL330 that is very different from Samsung SoCs'
Exactly what? We are already tested it our board and play the music well.
What's condition DMA aborts are happen?
>>> Of course, I address all such issues that I can think of, in my implementation.
>>
>> Ok, I'll rely on acked-by's from the interested parties once your
>> driver is out as I do not have a vested interest in this hardware,
>> just the dmaengine framework issues.
> Fair enough. Thank you.

As your previous mail, we can wait until this weekend. but If you
don't post the your codes until this weekend.
We assume that your works are not yet done so merge this patch first
and then fix it if your words(DMA aborts issue) are right.

Thank you,
Kyungmin Park
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/