Re: [PATCH] Prevent nested interrupts when the IRQ stack is nearoverflowing v2

From: David Miller
Date: Thu Mar 25 2010 - 15:42:02 EST


From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 25 Mar 2010 12:10:22 -0700 (PDT)

>
>
> On Thu, 25 Mar 2010, Ingo Molnar wrote:
>>
>> So the patch below should at most trigger bugs in areas that need fixing
>> anyway, and i'm quite sure that under no circumstance would it cause
>> unforeseen problems in 'thousands of drivers'.
>
> If we do this, then we should just remove all the IRQF_DISABLED code in
> kernel/irq/manage.c too, and basically make IRQF_DISABLED a clear no-op
> (still leave it around as a #define, to not break any users).

FWIW, I'm currently using IRQF_DISABLED for virtual network
device interrupts on sparc64 as a workaround for some stack
overflow issues.

This change will just force me to work harder to find out a better way
to fix the problem, so don't let my issue hold this back, it's just
an FYI...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/