Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer

From: Henrik Kretzschmar
Date: Thu Mar 25 2010 - 10:08:50 EST


Wolfram Sang schrieb:

> Hi Henrik,
>
> thanks for the work. Please, just keep the placement of those attributes
> consistent. Otherwise it might be easy to miss:
>
>
>> -static int sedlbauer_config(struct pcmcia_device *link);
>> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
>>
>
> Wrong.
>
>
>> -static int sedlbauer_probe(struct pcmcia_device *link)
>> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
>> {
>>
>
> Right.
>
> (I think checkpatch checks for this, too)
No, checkpatch doesn't claim about that.

Greets, Henrik

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/