Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
From: Wolfram Sang
Date: Thu Mar 25 2010 - 08:16:21 EST
Hi Henrik,
thanks for the work. Please, just keep the placement of those attributes
consistent. Otherwise it might be easy to miss:
> -static int sedlbauer_config(struct pcmcia_device *link);
> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
Wrong.
> -static int sedlbauer_probe(struct pcmcia_device *link)
> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
> {
Right.
(I think checkpatch checks for this, too)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature