Re: [GIT, RFC] Killing the Big Kernel Lock

From: Roland Dreier
Date: Wed Mar 24 2010 - 17:53:17 EST


Hi Arnd,

Interesting work. For the drivers/infiniband part, it seems maybe all
these drivers should be using no_llseek instead of default_llseek? (or
is it better style to use nonseekable_open()?) Certainly as far as I
can tell, nothing in drivers/infiniband pays any attention to f_pos.

Also, is there a reason why you add "#include <linux/smp_lock.h>" to all
the files where you also do ".llseek = default_llseek"?

In any case I can at least take care of the llseek stuff for 2.6.35.

- R.
--
Roland Dreier <rolandd@xxxxxxxxx>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/