Re: [PATCH 2/4] iwlwifi: don't include iwl-dev.h fromiwl-devtrace.h

From: reinette chatre
Date: Wed Mar 24 2010 - 13:55:55 EST


On Wed, 2010-03-24 at 01:48 -0700, Tejun Heo wrote:
> iwl-devtrace.h is used to declare and define trace points and
> including iwl-dev.h from the file, which in turn includes other
> generic headers can lead to problems like generating duplicate copies
> of generic trace points depending on the order of includes. Don't
> include iwl-dev.h from iwl-devtrace.h but include it from its users -
> iwl-io.h and iwl-devtrace.c.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Zhu Yi <yi.zhu@xxxxxxxxx>
> Cc: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Cc: Intel Linux Wireless <ilw@xxxxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> ---

Thank you

Acked-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/