Re: [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips

From: Greg KH
Date: Wed Mar 24 2010 - 11:57:51 EST


On Wed, Mar 24, 2010 at 08:43:07AM +0000, Alan Cox wrote:
> On Tue, 23 Mar 2010 19:28:03 -0700
> Greg KH <gregkh@xxxxxxx> wrote:
>
> > On Tue, Mar 23, 2010 at 03:41:09PM -0500, pavan_savoy@xxxxxx wrote:
> > > From: Pavan Savoy <pavan_savoy@xxxxxx>
> > >
> > > A new N_TI_WL line discipline added for TI BT/FM/GPS
> > > combo chips which make use of same TTY to communicate
> > > with chip. This is to be made use of individual protocol
> > > BT/FM/GPS drivers.
> > >
> > > Signed-off-by: Pavan Savoy <pavan_savoy@xxxxxx>
> > > ---
> > > include/linux/tty.h | 3 ++-
> >
> > Staging code needs to be completly self-contained in the drivers/staging
> > directory. Is there any way to do this without touching this file?
>
> Put the N_TI_WL into a staging header, and bump the number of ldiscs as a
> separate non staging patch - we should probably simply bump it a bit
> anyway to leave room for experimental work using a built kernel image.
> There is no requirement that the number of ldiscs matches up to the last
> ldisc assigned.

That sounds good to me.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/