Re: [PATCH] intel-agp.c: Fix crash when accessing nonexistent GTT entries in i915
From: Miguel Ojeda
Date: Tue Mar 23 2010 - 07:40:16 EST
On Tue, Mar 23, 2010 at 5:14 AM, Christian Kujau <lists@xxxxxxxxxxxxxxx> wrote:
> On Mon, 22 Mar 2010 at 20:57, Andrew Morton wrote:
>> On Sun, 21 Mar 2010 16:30:20 +0100 Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>> > I bisected in order to find the commit 5877960869333e42ebeb733e8d9d5630ff96d350.
>
> I believe this[0] is fc61901373987ad61851ed001fe971f3ee8d96a3 upstream:
Indeed. Also in
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.32.y.git;a=commit;h=fc61901373987ad61851ed001fe971f3ee8d96a3
>
> --------
> agp/intel-agp: Clear entire GTT on startup
>
> Some BIOSes fail to initialise the GTT, which will cause DMA faults when
> the IOMMU is enabled. We need to clear the whole thing to point at the
> scratch page, not just the part that Linux is going to use.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@xxxxxxxxx>
> [anholt: Note that this may also help with stability in the presence of
> driver bugs, by not drawing to memory we don't own]
> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
> --------
>
> Christian.
>
> [0] http://github.com/pfactum/pf-kernel/commit/5877960869333e42ebeb733e8d9d5630ff96d350
> --
> BOFH excuse #384:
>
> it's an ID-10-T error
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/