On Tue, 2010-03-23 at 10:03 +0800, Cong Wang wrote:Matt Mackall wrote:On Mon, 2010-03-22 at 04:17 -0400, Amerigo Wang wrote:I don't think it's a good idea, because we check if a deviceBased on the previous patch, make bridge support netpoll by:Not sure if this is the right thing to do. Shouldn't we simply enable
1) implement the 4 methods to support netpoll for bridge;
2) modify netpoll during forwarding packets in bridge;
3) disable netpoll support of bridge when a netpoll-unabled device
is added to bridge;
polling on all devices that support it and warn about the others (aka
best effort)?
supports netpoll by checking if it has ndo_poll_controller method.
Uh, what? If we have 5 devices on a bridge and 4 support netpoll, then
shouldn't we just send netconsole messages to those 4 devices? Isn't
this much better than simply refusing to work?