Re: [RFC Patch 2/3] bridge: make bridge support netpoll

[Cong Wang]

Matt Mackall wrote:
> On Mon, 2010-03-22 at 04:17 -0400, Amerigo Wang wrote:
> > Based on the previous patch, make bridge support netpoll by:
> >
> > 1) implement the 4 methods to support netpoll for bridge;
> >
> > 2) modify netpoll during forwarding packets in bridge;
> >
> > 3) disable netpoll support of bridge when a netpoll-unabled device
> >    is added to bridge;
>
> Not sure if this is the right thing to do. Shouldn't we simply enable
> polling on all devices that support it and warn about the others (aka
> best effort)?

I don't think it's a good idea, because we check if a device
supports netpoll by checking if it has ndo_poll_controller method.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/