Re: [PATCH 06/20] early_res: seperate common memmap func frome820.c to fw_memmap.c

[Benjamin Herrenschmidt]

On Mon, 2010-03-22 at 22:20 +0100, Ingo Molnar wrote:
> 
> So no arguments from me at all about the code quality aspects - i just wanted 
> to highlight the huge amount of non-trivial work Yinghai has invested into 
> this already, with little external help, and that if possible it would be nice 
> to minimize the upsetting of related x86 code if possible. Please help him out 
> with more specific suggestions about how the two memory allocation spaces 
> could be unified best, to serve the needs of all these architectures - if you 
> have some spare time. 

Why not start by unifying the APIs to it, while keeping the
implementation in the arch for now ? That would be a good first step and
would give us a good idea of what kind of requirements all the archs
have since to some extent those requirements need to be represented in
this API.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/