Re: [PATCH linux-cr] nested pid namespaces (v2)

From: Matt Helsley
Date: Mon Mar 22 2010 - 15:57:43 EST


On Mon, Mar 22, 2010 at 09:38:00AM -0500, Serge E. Hallyn wrote:
> Quoting Louis Rilling (Louis.Rilling@xxxxxxxxxxx):
> > On Fri, Mar 19, 2010 at 04:39:55PM -0500, Serge E. Hallyn wrote:
> > > Support checkpoint and restart of tasks in nested pid namespaces. At

<snip>

> > It would probably be safer too to use task_active_pid_ns() instead of
> > task->nsproxy->pid_ns, just in case some PID namespace unsharing like proposed
> > by Eric makes it to mainline.
>
> The task is frozen though so it shouldn't be able to unshare while being
> checkpointed, right? But it's probably better code anyway.

By the time it reaches checkpoint a frozen task is in the refrigerator
-- most often in the signal delivery portion of syscall return. So it can't
be making any new unshare/setns syscalls and any changes to the namespaces
should be visible.

Cheers,
-Matt Helsley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/