Re: [patch] x86: handle legacy PIC interrupts on all the cpu's

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> 
> > On 03/15/2010 03:56 PM, Suresh Siddha wrote:
> > > On Mon, 2010-03-15 at 14:51 -0700, Yinghai Lu wrote:
> > >>> +	for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
> > >>> +		if (!IO_APIC_IRQ(irq))
> > >>> +			per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
> > >>
> > >> seems those three lines are not needed...
> > > 
> > > Those are needed for !CONFIG_X86_IO_APIC case.
> > > 
> > then we can have
> > 
> > +#ifndef CONFIG_X86_IO_APIC
> > +	for (irq = 0; irq < legacy_pic->nr_legacy_irqs; irq++)
> > +		per_cpu(vector_irq, cpu)[IRQ0_VECTOR + irq] = irq;
> > +#endif
> > 
> > then we don't punish most setup with ioapic controller.
> 
> Ok - i've simplified the code with the above and have added your Acked-by - is 
> that is fine by you?

btw., the patch fixes the regression on the testbox - thanks Suresh!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/