Re: [PATCH -next] staging/pohmelfs: fix write_inode parameter warning

[Geert Uytterhoeven]

On Thu, Feb 25, 2010 at 23:41, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> sparse warns that:

Not just sparse, plain gcc as well...

> drivers/staging/pohmelfs/inode.c:1797: warning: initialization from incompatible pointer type
>
> so fix pohmelfs_write_inode() to have the expected parameters.

And now it's in mainline, too...

> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> ---
> Âdrivers/staging/pohmelfs/inode.c | Â Â3 ++-
> Â1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20100225.orig/drivers/staging/pohmelfs/inode.c
> +++ linux-next-20100225/drivers/staging/pohmelfs/inode.c
> @@ -396,7 +396,8 @@ int pohmelfs_remove_child(struct pohmelf
> Â/*
> Â* Writeback for given inode.
> Â*/
> -static int pohmelfs_write_inode(struct inode *inode, int sync)
> +static int pohmelfs_write_inode(struct inode *inode,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct writeback_control *wbc)
> Â{
> Â Â Â Âstruct pohmelfs_inode *pi = POHMELFS_I(inode);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/