Re: [RESEND PATCH 0/2] Make functions of dev_<level> macros, recursivevsnprintf

From: Linus Torvalds
Date: Sat Mar 06 2010 - 17:57:59 EST




On Sat, 6 Mar 2010, Linus Torvalds wrote:
>
> I'm not convinced. We pass that 'printf_spec' around a lot, including
> nesting. Not as a pointer, either.

Btw, I wonder if those fields could become bitfields, or 'unsigned char'
etc. That printf_spec really is unnecessarily big. It should _easily_ fit
in a single register on a 64-bit platform, possibly even a 32-bit one (we
could limit field width and precision to 5 bits, for example)

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/