Re: [patch] joystick: off by one error

[Dan Carpenter]

On Sat, Mar 06, 2010 at 02:09:44PM +0300, Dan Carpenter wrote:
> This fixes a smatch warning:
> drivers/input/joystick/gamecon.c +838 gc_setup_pad(23) error: buffer overflow 'gc_names' 10 <= 10
> 

Crap.  I already sent this patch.  I'm really sorry about that.

I will fix my QC process to not do this again.

regards,
dan carpenter

> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c
> index ae998d9..7a55714 100644
> --- a/drivers/input/joystick/gamecon.c
> +++ b/drivers/input/joystick/gamecon.c
> @@ -819,7 +819,7 @@ static int __init gc_setup_pad(struct gc *gc, int idx, int pad_type)
>  	int i;
>  	int err;
>  
> -	if (pad_type < 1 || pad_type > GC_MAX) {
> +	if (pad_type < 1 || pad_type >= GC_MAX) {
>  		pr_err("Pad type %d unknown\n", pad_type);
>  		return -EINVAL;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/