[patch] dynamic_debug: small clean up in ddebug_proc_write()

From: Dan Carpenter
Date: Sat Mar 06 2010 - 06:02:20 EST


This the doesn't change behavior at all. In the original code, if nwords
was zero then ddebug_parse_query() would return -EINVAL, now we just do
it earlier.

Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index f935029..4482f9d 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -455,7 +455,7 @@ static ssize_t ddebug_proc_write(struct file *file, const char __user *ubuf,
__func__, (int)len);

nwords = ddebug_tokenize(tmpbuf, words, MAXWORDS);
- if (nwords < 0)
+ if (nwords <= 0)
return -EINVAL;
if (ddebug_parse_query(words, nwords-1, &query))
return -EINVAL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/