Re: [RFC][PATCH 2/3] perf: Take a hot regs snapshot for traceevents

[Frederic Weisbecker]

On Thu, Mar 04, 2010 at 10:52:36PM +0100, Thomas Gleixner wrote:
> On Thu, 4 Mar 2010, Frederic Weisbecker wrote:
> 
> > On Thu, Mar 04, 2010 at 04:30:38PM -0500, Steven Rostedt wrote:
> > > On Thu, 2010-03-04 at 22:17 +0100, Ingo Molnar wrote:
> > > > * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > > > 
> > > 
> > > > No, we want to decouple it from 'tracing'. It's events, not tracing. Events 
> > > > are more broader, they can be used for RAS, profiling, counting, etc. - not 
> > > > just tracing.
> > > > 
> > > > Furthermore, we only want /debug/tracing/events really, not the various 
> > > > dynamic ftrace controls - those could remain in /debug/tracing/.
> > > 
> > > I was talking about the files in the events directory:
> > > 
> > > events/sched/sched_switch/{id,format,enable,filter}
> > > 
> > > 
> > > Seems only the format file should go in, and perhaps the id.
> > > 
> > > I can keep the debug/tracing/events/* as is too, where the format and id
> > > just call the same routines that the eventfs calls, but add the enable
> > > and filter to be specific to ftrace.
> > 
> > 
> > The /debug/tracing/events could contain symlinks for the format
> > files so that the rest can stay there.
> 
> Are you proposing to create another sysfs symlink maze ?
> 
> Thanks,
> 
> 	tglx


I don't know, I like the idea of generalizing the events, but I hope
it won't be at the detriment of ftrace usability.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/