Re: [PATCH 3/3] cpufreq: add sysfs knob for toggling coreperformance boost
From: Borislav Petkov
Date: Thu Mar 04 2010 - 16:49:26 EST
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, Mar 04, 2010 at 01:27:43PM -0800
> The lack of any changelog in a patch is usually a good sign that the
> patch needs a changelog :(
See my earlier mail.
[..]
> Well I've read the code and I've read the code comments and I've read
> the changelogs and I still have no clue what this thing does.
> Apparently it allows me to toggle something called "APERF/MPERF". I
> guess if I were patient enough, teh goog might tell me what that is,
> and why I might want it. But this is all terribly inefficient.
>
> I think you'd find that your feature is more useful and will be used by
> more people if you tell them (and us) what it does.
Basically, this is a knob for toggling of a core boosting feature
we have in Fam10h, rev.E CPUs. I'll have a proper changelog with a
hopefully understandable explanation soon :).
Thanks.
--
Regards/Gruss,
Boris.
-
Advanced Micro Devices, Inc.
Operating Systems Research Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/