Re: [PATCH] perf_events: add sampling period randomization support(v2)

[Ingo Molnar]

* eranian@xxxxxxxxxx <eranian@xxxxxxxxxx> wrote:

> This patch adds support for randomizing the sampling period.  Randomization 
> is very useful to mitigate the bias that exists with sampling. The random 
> number generator does not need to be sophisticated. This patch uses the 
> builtin random32() generator.

> +	if (width > 63 || attr->freq)
> +		return -EINVAL;

Why not for freq counters? Those are semi-randomized already, but it might 
make sense to make them 'more' randomized in special circumstances. That would 
also allow us to enable the randomization in perf top and perf record, by 
default.

Without that we'd have no immediate usecase and no way to ensure that this 
code works as intended.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/