Re: [PATCHv2] drivers: net: optimize hex2bin()

From: Geoff Levand
Date: Wed Mar 03 2010 - 17:13:39 EST


Hi,

On 03/02/2010 08:04 AM, Levand, Geoffrey wrote:
> On 03/01/2010 11:59 PM, Andy Shevchenko wrote:
>> Optimize hex2bin() function used in ps3_gelic_wireless.c. It requires to have
>> hex_to_bin() implementation introduced by starter patch [1] in series.
>>
>> [1] http://patchwork.kernel.org/patch/81224/
>>
>> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@xxxxxxxxx>
>> Cc: Geoff Levand <geoffrey.levand@xxxxxxxxxxx>
>> ---
>> drivers/net/ps3_gelic_wireless.c | 13 +++++--------
>> 1 files changed, 5 insertions(+), 8 deletions(-)
>
> Looks good, thanks.
>
> Acked-by: Geoff Levand <geoffrey.levand@xxxxxxxxxxx>

Sorry, this is now a NAK.

Some PS3 driver clean-ups were merged, and Andy's change
is no longer needed. Here is the commit:

c1596b75c29eb5b32c65ef1e186c8b08c289bf05 - ps3_gelic_wireless: Remove PS3 gelic legacy wpa support

Sorry for asking for an updated patch when this
other change was queued.

-Geoff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/