Re: [PATCH 01/11] ahci: Get rid of host->iomap usage

[Jeff Garzik]

On 03/03/2010 01:45 PM, Jeff Garzik wrote:
> On 03/03/2010 12:17 PM, Anton Vorontsov wrote:
> > Currently the driver uses host->iomap to store all the iomapped BARs
> > of a PCI device (while AHCI devices actually use just a single memory
> > window).
> >
> > We're going to teach AHCI to work with non-PCI buses, so there are two
> > options to make this work:
> >
> > 1. "fake" host->iomap array for non-PCI devices, and place the needed
> > address at iomap[AHCI_PCI_BAR];
> > 2. Get rid of host->iomap usage, instead introduce a private mmio
> > field.
> >
> > This patch implements the second option.
> >
> > Signed-off-by: Anton Vorontsov<avorontsov@xxxxxxxxxxxxx>
> > ---
> > drivers/ata/ahci.c | 34 ++++++++++++++++++++--------------
> > 1 files changed, 20 insertions(+), 14 deletions(-)
>
> Does platform code not contain any devres support?
>
> At a minimum, you should be using devm_ioremap(), yes?

Nevermind, I see this now in the platform driver.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/