Re: [PATCH 09/11] ahci: Move generic code into libahci

[Sergei Shtylyov]

Hello.

Anton Vorontsov wrote:

> This patch should contain no functional changes, just moves code
> around.
>
> Currently libahci.c and ahci.c are built into a single module,
> so there is no need for EXPORT_SYMBOL_GPL()s, yet. Exports will be
> added in a subsequent patch.
>   

  This is not true anymore, so the exports are probably needed.

> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxxxxx>
> ---
>  drivers/ata/Makefile  |    2 +-
>  drivers/ata/ahci.c    | 2271 +------------------------------------------------
>  drivers/ata/libahci.c | 2059 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/ata/libahci.h |  330 +++++++
>  4 files changed, 2391 insertions(+), 2271 deletions(-)
>  create mode 100644 drivers/ata/libahci.c
>  create mode 100644 drivers/ata/libahci.h
>
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index b7d4923..75e3abd 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -1,7 +1,7 @@
>  
>  obj-$(CONFIG_ATA)		+= libata.o
>  
> -obj-$(CONFIG_SATA_AHCI)		+= ahci.o
> +obj-$(CONFIG_SATA_AHCI)		+= libahci.o ahci.o
>   

  This means 2 different modules: libahci.ko and ahci.ko.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/