Re: [GIT PULL] x86/mm fixes

From: Wu Fengguang
Date: Tue Mar 02 2010 - 21:10:07 EST


On Wed, Mar 03, 2010 at 03:31:48AM +0800, H. Peter Anvin wrote:
> On 03/02/2010 10:39 AM, Linus Torvalds wrote:
> >
> >
> > On Tue, 2 Mar 2010, H. Peter Anvin wrote:
> >> + pfn = (res.start + PAGE_SIZE - 1) >> PAGE_SHIFT;
> >> + end_pfn = (res.end + 1) >> PAGE_SHIFT;
> >> + if (end_pfn > pfn)
> >> + ret = (*func)(pfn, end_pfn - pfn, arg);
> >> if (ret)
> >> break;
> >> res.start = res.end + 1;
> >
> > What kind of messed-up indentation is that? We don't use 4-char indents.
> >
>
> Branch updated with an indentation patch. Sorry about that.

Sorry! Wondering I didn't do the indent with the vim '=='.

Anyway I just hacked /usr/share/quilt/refresh to automatically run the
kernel style checker:

# wfg: check for kernel coding style
if [ -x scripts/checkpatch.pl ]; then
scripts/checkpatch.pl $patch_file
fi

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/