Re: [PATCH 2/2] ocfs2: ensure trusted xattrs are not returned tounprivileged users via listxattr

[James Morris]

On Tue, 2 Mar 2010, Joel Becker wrote:

> On Tue, Mar 02, 2010 at 07:02:22PM +1100, James Morris wrote:
> > Ensure that trusted xattrs are not returned to unprivileged users
> > via listxattr, in keeping with several other implmentations, such
> > as ext3.
> > 
> > Signed-off-by: James Morris <jmorris@xxxxxxxxx>
> 
> If this is the standard expectation, why not lift it up into the vfs?

The VFS doesn't know what's in the listxattr list.  When using generic 
xattr handlers for synthetic xattrs, it's easy to determine the xattr 
namespace (each namespace has a handler), although on-disk xattrs need to 
be read from disk to determine if they're in the trusted namespace.

The VFS could possibly modify the listxattr results after the fact, 
although it's very ugly, and it would not be able to correctly handle size 
probes, where the VFS only sees a total size value from the FS.


- James
-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/