RE: [PATCH] serial: Add OMAP high-speed UART driver.

From: Shilimkar, Santosh
Date: Tue Mar 02 2010 - 09:04:22 EST


<snip snip>
> > > --
> > CDAC is a shadow register used for monitoring the DMA channel.
> > I think it would be a lot
> > simpler if omap_start_dma() always resets CDAC to 0, and the
> > UART driver
> > just not set it explicitly.
>
> This seems to be better option than exposing CDAC read/write API
> to other drivers since user need to write '0' before starting any DMA
> transfer which can be be done in omap_start_dma().
>
> I am wondering how other drivers are using DMA transfer API's without
> resetting CDAC to zero.
>
It's needed only if some one is interested in that count. UART seems to
using this counter where as other driver don't.

Why do you think drivers need to know about counter value ?

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/