Re: [PATCH RFC] kconfig: place git SHA1 in .config output if ingit tree

[Paul E. McKenney]

On Mon, Mar 01, 2010 at 08:53:19PM -0500, James Cloos wrote:
> >>>>> "Paul" == Paul E McKenney <paulmck@xxxxxxxxxxxxxxxxxx> writes:
> 
> Paul> Agreed!  The "-dirty" modifier for the case of changes not yet
> Paul> checked into git looks especially helpful.
> 
> JimC> Except that the script calls Âgit update-index --refresh --unmergedÂ
> JimC> and Âgit diff-index --name-only HEADÂ, both of which are painfully
> JimC> slow and resource intensive.
> 
> JimC> I'd hate to have that run every time I make a kernel.
> 
> Paul> Good point...  Should we have an environment variable that controls
> Paul> this behavior?
> 
> I wouldn't mind the intial idea: just the abbreviated top of three hash.
> 
> I was, next, going to write that CONFIG_LOCALVERSION_AUTO already exists
> for that, but LOCALVERSION_AUTO calls scripts/setlocalversion these days
> and that is what I'd prefer to avoid.  [SIGH]
> 
> Shows how long it has been since I last used it.  I stopped using it
> when I was maintaining my .config in git.  Now I maintain .config in a
> separate git repo, for the express purpose of avoiding a merge (rather
> than a fast forward) when I run git pull.  Something that a local edit
> of scripts/setlocalversion will, of course, prevent.
> 
> Anyone up for a CONFIG_LOCALVERSION_AUTO_DO_NOT_BOTHER_WITH_DIRTY? â

It looks like it would be pretty easy to make make scripts/setlocalversion
look at an environment variable to decide whether or not to do the index
update and the check for uncommitted changes.  Default would seem to
need to be to do it the slow way.

Or would that cause other problems?

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/