Re: [PATCH v1] compiler: prevent dead store elimination

[Andi Kleen]

On Sun, Feb 28, 2010 at 09:15:11PM -0800, Arjan van de Ven wrote:
> On Sat, 27 Feb 2010 21:47:42 +0100
> Roel Kluin <roel.kluin@xxxxxxxxx> wrote:
> > +void secure_bzero(void *p, size_t n)
> > +{
> > +	memset(p, 0, n);
> > +	ARRAY_PREVENT_DSE(p, n);
> > +}
> > +EXPORT_SYMBOL(secure_bzero);
> 
> 
> please don't introduce bzero again to the kernel;
> 
> make it secure_memset() please.

Would there ever be any reason to set the key to something
else than 0? 

IMHO bzero is less error prone. With memset there are regular 
bugs when the two end arguments get exchanged. 

You could call it differently if you have a problem with old BSD
names, but inherently there's nothing wrong with them. One possibility
would be the same name as VC++ uses.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/