Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in git tree

[Frans Pop]

On Monday 01 March 2010, Paul E. McKenney wrote:
> Hmmm...  In that case, it won't find the scripts/setlocalversion script,
> either.  Unless you have the git tree on your $PATH, which seems
> unlikely.  So I can just check for popen() failure and take corrective
> action.

It doesn't work for me yet, but I don't see why not. It does work when I do 
e.g. a 'make defconfig' in the current directory, but not when I set 
KBUILD_OUTPUT.

It's probably easiest if you try to debug it yourself. It's as simple as:
$ mkdir /tmp/kbuild
$ KBUILD_OUTPUT=/tmp/kbuild make defconfig


One other thing. I wonder if this implementation will always reliably 
result in the *current* SHA1 being included in the .config. AFAICT 
the .config only actually gets written if there are changes, or if you 
explicitly do a 'make oldconfig'.

But if you e.g. pull a stable update and just run 'make', the .config will 
likely remain unchanged and will thus still contain the SHA1 from a 
previous build.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/