[PATCH 1/5] lib: fix atomic64_add_unless test

From: Luca Barbieri
Date: Mon Mar 01 2010 - 13:56:55 EST


atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Reported-by: H. Peter Anvin <hpa@xxxxxxxxx>
Signed-off-by: Luca Barbieri <luca@xxxxxxxxxxxxxxxxx>
---
lib/atomic64_test.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
index 58efdab..ee8e6de 100644
--- a/lib/atomic64_test.c
+++ b/lib/atomic64_test.c
@@ -104,11 +104,11 @@ static __init int test_atomic64(void)
BUG_ON(v.counter != r);

INIT(v0);
- BUG_ON(!atomic64_add_unless(&v, one, v0));
+ BUG_ON(atomic64_add_unless(&v, one, v0));
BUG_ON(v.counter != r);

INIT(v0);
- BUG_ON(atomic64_add_unless(&v, one, v1));
+ BUG_ON(!atomic64_add_unless(&v, one, v1));
r += one;
BUG_ON(v.counter != r);

--
1.6.6.1.476.g01ddb

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/